fix(ui): fix CoreDataFrame download for big file. WF-39#497
Merged
ramedina86 merged 1 commit intowriter:devfrom Jul 29, 2024
Merged
fix(ui): fix CoreDataFrame download for big file. WF-39#497ramedina86 merged 1 commit intowriter:devfrom
CoreDataFrame download for big file. WF-39#497ramedina86 merged 1 commit intowriter:devfrom
Conversation
The issue was too many parameters was given to `String.fromCharCode()` and make and error like "Maximum call stack size exceeded". In fact, there is no need to try to convert the CSV to base64. So I simply used `Blob` and then `URL.createObjectURL` instead which should be more efficient.
Contributor
FabienArcellier
left a comment
There was a problem hiding this comment.
I test with a dataframe of 1 million lines with success.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was too many parameters was given to
String.fromCharCode()and make and error like "Maximum call stack size exceeded".In fact, there is no need to try to convert the CSV to base64. So I simply used
Bloband thenURL.createObjectURLinstead which should be more efficient.Note, it also improve the mime/type declared, which make the OS open the file with a better software (Libreoffice instead of Text Editor for me)