fix: handle template in BuilderFieldsKeyValue. WF-31#484
Merged
ramedina86 merged 1 commit intowriter:devfrom Jul 30, 2024
Merged
fix: handle template in BuilderFieldsKeyValue. WF-31#484ramedina86 merged 1 commit intowriter:devfrom
BuilderFieldsKeyValue. WF-31#484ramedina86 merged 1 commit intowriter:devfrom
Conversation
Collaborator
|
Beautiful work! Love when things become simpler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was
BuilderFieldsKeyValuedidn't interpret the template syntax and try toJSON.parseit when navigating between "Static List" and "JSON".I fixed it relying on
useEvaluator().getEvaluatedFieldswhich take care of getting the current data and parsing template. It simplify a lot the logic of the component!It just required that I get and parse
instancePathin the parent.Now everything works as expected, if user modify a template value in "Static list" mode, the template is overwiten by the plain JSON value. We still handle the "undo/redo" as expected.
Screencast.from.2024-07-01.23-45-17.webm