chore: (minor) extending the Evaluator regex#289
Merged
ramedina86 merged 7 commits intowriter:devfrom Apr 23, 2024
Merged
Conversation
mmikita95
commented
Mar 7, 2024
src/streamsync/core.py
Outdated
| """ | ||
|
|
||
| template_regex = re.compile(r"[\\]?@{([\w\s.\[\]]*)}") | ||
| template_regex = re.compile(r"[\\]?@{([\w\s.\[\]]*)}", re.U) |
Contributor
Author
There was a problem hiding this comment.
As I eventually found out, this flag is redundant and included for backward compatibility. Won't be added as per latest commit.
ramedina86
reviewed
Apr 23, 2024
mmikita95
commented
Apr 23, 2024
| """ | ||
|
|
||
| template_regex = re.compile(r"[\\]?@{([\w\s.\[\]]*)}") | ||
| template_regex = re.compile(r"[\\]?@{([^{]*)}") |
Contributor
Author
There was a problem hiding this comment.
r"[\\]?@{([^{]*)}"
[\\]: matches a single character present in the list (\\ matches the character \ literally)
@{: matches the characters @{ literally
Capturing Group ([^{]*): matches a single character not present in the list (excludes {)
*: matches the previous token between zero and unlimited times, as many times as possible, giving back as needed (greedy)
}: matches the character } literally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a dash to this regular expression enables support for "skewer-case" state property names on frontend side.