feat: Chat, Step, Steps, RatingInput components#271
Conversation
|
@raaymax Can you help me by reviewing this one? No need to look at every line of code but I'd appreciate your input when it comes to standards, e.g. conventional commits. Am I using these correctly? Apologies for the big PR. |
ui/src/core/templateMap.ts
Outdated
| import CoreChat from "../core_components/content/CoreChat.vue"; | ||
| import CoreStep from "../core_components/layout/CoreStep.vue"; | ||
| import CoreSteps from "../core_components/layout/CoreSteps.vue"; | ||
| import CoreRating from "../core_components/input/CoreRatingInput.vue"; |
There was a problem hiding this comment.
suggestion(non-blocking): All imports are sorted by folder currently, we can sort them further or just remove comments from above.
There was a problem hiding this comment.
Thanks, I'll sort it.
I used to be part of a team that had a linting rule (I think it was a linting rule) that automatically applied alphabetical order to imports. What are your thoughts? Is this worth it?
| incomingInitials: { | ||
| name: "Incoming initials", | ||
| default: "AI", | ||
| type: FieldType.Text, | ||
| }, |
There was a problem hiding this comment.
question: shouldn't this come from message?
There was a problem hiding this comment.
In a normal chat, absolutely. But since this is in fact a component to create chatbots, it's expected that it'll always be the same entity. "AI" or for example if you want to create a "Coding Companion", "CC".
Not requiring this also allows you to simply pass a string for the response which is nice.
Perhaps the question is, should this component be named "chatbot" instead?
|
Generally about conventional commits it's totally up to us whats valid but generally it's just |
No description provided.