Merged
Conversation
Collaborator
|
Sounds great, @FabienArcellier thoughts? @raaymax What were the issues from the previous PR that the linter would have caught? (just curious) |
Collaborator
Author
|
Now as I review this PR, there isn't really much there. Actually, just console.log. Anyway, in the meantime, I fixed more things on my own, which is why it seemed like there was more. |
Collaborator
Author
|
From all this changes I only added missing |
Collaborator
|
Hey @raaymax are we good to merge this? |
Collaborator
Author
|
If @FabienArcellier doesn't have any more comments, then yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On previous PR we lost some time fixing issues that should be handled by linter.
I checked and noticed that eslint was not working in the project so i fixed it.
Additionally added GH actions workflow for lint checking