Conversation
Adding a class method to count initial mutations for a StateProxy. Checking the amount of mutations per each step of the test to ensure that mutations are properly tracked.
Collaborator
|
Nice tests! I'm not a hardcore test fanatic, but for these specific matters they're really helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a class method to count initial mutations for a StateProxy. Checking the amount of mutations per each step of the test to ensure that mutations are properly tracked.In regards to our prior discussion with @ramedina86, I found that the most reliable way to avoid issues like #198 in the future is to consistently track how many mutations are produced by the
get_mutations_as_dictmethod inStateProxy, and compare the amount to the "ground truth" (i.e. actual number of mutations, which is easily deductible). I updated the mutation test to do exactly that. A method that counts expected "initial mutations" was also added, to make the test independent from the state of the dictionary initially passed toTestStateProxy.I will be considering designing other tests as well, and any feedback is appreciated on the way.