Add 'password_hash' and 'password_hash_type' to User creation #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverzheng
approved these changes
Apr 5, 2024
lib/UserManagement.php
Outdated
| * @param string|null $lastName The last name of the user. | ||
| * @param boolean|null $emailVerified A boolean declaring if the user's email has been verified. | ||
| * @param string|null $passwordHash The hashed password to set for the user. | ||
| * @param string|null $passwordHashType The algorithm originally used to hash the password. Valid values are bcrypt. |
Contributor
There was a problem hiding this comment.
Suggested change
| * @param string|null $passwordHashType The algorithm originally used to hash the password. Valid values are bcrypt. | |
| * @param string|null $passwordHashType The algorithm originally used to hash the password. Valid values are `bcrypt`, `ssha`, and `firebase-scrypt`. |
The updateUser docs that this was copied from needs an update as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that the User create process allows for the
password_hashandpassword_hash_typefields, in addition to the existingpasswordfield, similar to the Update process.Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.
https://github.com/workos/workos/pull/26060