Skip to content

chore: fixing type errors with core members json #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2022
Merged

chore: fixing type errors with core members json #1529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/about/team/Member.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ export interface Member {
languages: string[]
website?: Link
socials: Socials
sponsor?: string
sponsor?: boolean | string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a quick search, it looks like this field is only used in one place, which uses it for a v-if. I think the handful of entries with string values are leftover from an incomplete migration and should just be switched to true instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a button for sponsors? image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sorry, that's what I meant. That button in TeamMember.vue seems to be the only place that uses the sponsor property and it just treats it as a boolean. There are 5 people in members-core.json that have a string value for sponsor, but I believe they should all just be switched to true, and then sponsor doesn't need to support the string type.

reposPersonal?: string[]
}

export interface Link {
Expand Down
2 changes: 1 addition & 1 deletion src/about/team/members-core.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@
"name": "Rahul Kadyan",
"title": "Software Engineer",
"company": "Grammarly",
"companyList": "https://grammarly.com/",
"companyLink": "https://grammarly.com/",
"projects": [
{
"label": "vuejs/core",
Expand Down