Skip to content

Conversation

@ji-huazhong
Copy link
Collaborator

What does this PR do?

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the veomni backend for RL training. It introduces new configuration files for veomni actor, critic, reference policy, and reward models, along with a main PPO trainer configuration. The changes also update the worker selection logic to handle the veomni strategy.

My review has identified a few critical issues in the new configuration files that would lead to runtime errors. Specifically, a misconfigured legacy worker flag, a non-portable model path, and a placeholder value that needs to be replaced. There is also a minor redundancy in one of the configuration files. Addressing these points will improve the correctness and usability of the new veomni backend configuration.


# whether to use legacy worker implementation
# mode: "auto", "enable", or "disable"
use_legacy_worker_impl: auto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The use_legacy_worker_impl is set to auto, but the veomni backend requires the new worker implementation. With the auto setting, the application will raise a NotImplementedError for the actor worker or a ValueError for the critic worker. To ensure the veomni backend functions correctly, this value must be set to disable.

  use_legacy_worker_impl: disable

nnodes: 0

model:
path: ~/models/FsfairX-LLaMA3-RM-v0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The model path ~/models/FsfairX-LLaMA3-RM-v0.1 uses a tilde (~) to refer to the user's home directory. This is not portable and will cause errors in environments like Docker containers or when run by different users. Please use a placeholder or a more robust path resolution mechanism, such as an environment variable, to make the configuration more robust and reproducible.

  path: <path_to_FsfairX-LLaMA3-RM-v0.1_model>


rollout:
_target_: verl.workers.config.RolloutConfig
name: ???
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The rollout.name is set to ???, which is a placeholder and will cause a runtime error. Please replace it with a valid rollout engine name (e.g., vllm, sglang).

  name: <your_rollout_engine_name>

# before the current forward computation.
forward_prefetch: true

strategy: veomni
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The strategy: veomni key is defined inside the veomni block, but it's also defined at the top level of this configuration file (line 10). This redundancy can be confusing and lead to maintenance issues. Please remove this nested strategy key.

@wuxibin89 wuxibin89 mentioned this pull request Jan 12, 2026
24 tasks
@ji-huazhong ji-huazhong changed the title add rl support for veomni backend [WIP] add rl support for veomni backend Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant