Introduce new subcmd edit
#278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release v0.3.5
Release v0.3.5a
Allows editing the plugconf file(s) of the given repositories. Closes vim-volt#230 There are still a few FIXMEs in the code. The most important one being: - Which error codes to use? Currently 15 and 20 are used, but the existing error codes are not documented. It is unclear whether to reuse an existing one or which to use for which purpose. The remaining ones are more about clean code and a different option
tyru
requested changes
Apr 18, 2019
Member
|
Addition to above, could you add an simple example of |
Member
|
And please change target branch to |
15cce6d to
3621dfe
Compare
tyru
requested changes
Apr 23, 2019
Member
tyru
left a comment
There was a problem hiding this comment.
Thanks. Also modifying bash script is a good catch.
Co-Authored-By: hupfdule <36069345+hupfdule@users.noreply.github.com>
tyru
approved these changes
Apr 26, 2019
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows editing the plugconf file(s) of the given repositories.
Closes #230
There are still a few FIXMEs in the code.
The most important one being:
Currently 15 and 20 are used, but the existing error codes are not
documented. It is unclear whether to reuse an existing one or which to
use for which purpose.
The remaining ones are more about clean code and a different option