Open
Conversation
Open
Contributor
|
I don't see this causing an issue on any existing implementations. In theory we could also accomplish this with ID 0, but it would require a bit of logic in implementations that don't explicitly encode the ID in the handle (namely XG). So yeah, I see the benefit. |
Contributor
|
Is there a reason this never got merged? I have an idea I want to try out, and I would need something along these lines for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An example of a null handle as proposed in #22. I think this is handy, especially when re-working existing code that may rely on checks of the form
Node* == nullptrorid == 0.It's a trivial addition to the interface, but imposes a condition that all implementations reserve the chosen value. Thoughts?