Conversation
jayqi
approved these changes
Apr 11, 2024
Collaborator
jayqi
left a comment
There was a problem hiding this comment.
LGTM. Tested it in the console as well, and it looks to work as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do.callwith the function argument as string will now properly appear on the function reporter. Previously, this would show as ado.callnode with a circular reference. (#302)This bit of code checks the recursion step for a list with a
do.callcall as the first element and a string as the second. If true, it converts the string to a call, and then continues with the recursion.Note:
baseballstatstest package is changed, BUT because this do.call is in place, network remains identical. Therefore, unit test for this edge case included.