Conversation
…amak into update_component_tests
…amak into update_component_tests
…amak into update_component_tests
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
…amak into update_component_tests
…aea/paramak into neutronics_simulations_for_components
Neutronics simulations for components
added new tf princeton d coil image
removed printing of largest dim
…aea/paramak into neutronics_simulations_for_components
Neutronics simulations for components
Develop pre review
Codecov Report
@@ Coverage Diff @@
## main #638 +/- ##
==========================================
+ Coverage 91.68% 98.59% +6.91%
==========================================
Files 63 68 +5
Lines 3607 4125 +518
==========================================
+ Hits 3307 4067 +760
+ Misses 300 58 -242
Continue to review full report at Codecov.
|
shimwell
commented
Dec 17, 2020
allowing floats and ints for batches and particles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is the v0.02 release with planned features implemented from the project board https://github.com/ukaea/paramak/projects/2
This is the second release of the project and is being merged to main just before the pullrequest.com review is completed. The next version will include some improvements from the pullrequest.com review
Breaking hange
- RENAMED
NeutronicsModelFromReactortoNeutronicsModeland replaced thereactorarg name withgeometryThese include:
In addition to these planned features and improvements there were some additional improvements:
Adding neutronics simulations to the CI on circle and github actions
Adding optional neutronics to the dockerfile as a build arg
Adding a (award winning) video presentation to the readme and docs
added new paramentric component:
-- CoolantChannelRingStraight
-- CoolantChannelRingCurved
-- RotatedTrapezoid
-- RotatedIsoscelesTriangle
-- ShellFS
-- HollowCube (refactoring of the graveyard)
refactored the export to h5m via the pymoab route so that shapes can be exported as well as reactors
lots and lots of new tests and an increased code coverage
reactors and shapes now have a largest_dimension which helps with the DAGMC - graveyard refactoring
Shapes now have a .wire attribute and this can be exported via the export_stp(mode='wire')
improved documentation on the VacuumVesselstp, neutronics model
added an example of a component based parameter study in neutronics
Improved ToroidalFieldCoilPrincetonDsvg images in docs
Types of changes
What types of changes does your code introduce to the Paramak?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...