Skip to content

Neutronics simulations for components#637

Merged
shimwell merged 3 commits intodevelop_pre_reviewfrom
neutronics_simulations_for_components
Dec 16, 2020
Merged

Neutronics simulations for components#637
shimwell merged 3 commits intodevelop_pre_reviewfrom
neutronics_simulations_for_components

Conversation

@shimwell
Copy link
Collaborator

Proposed changes

Just changes the materials so that they work with the nuclear data on the dockerfile

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@shimwell shimwell merged commit 1176ddd into develop_pre_review Dec 16, 2020
@shimwell shimwell deleted the neutronics_simulations_for_components branch December 16, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant