Conversation
removed recreation of reactor as suggested by review
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com> Co-authored-by: John Billingsley <56687624+billingsley-john@users.noreply.github.com>
Co-authored-by: John Billingsley <56687624+billingsley-john@users.noreply.github.com>
Adding face
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
added shellFS component and tests
🎉 not all reactors need rotation angles
Codecov Report
@@ Coverage Diff @@
## develop #632 +/- ##
===========================================
+ Coverage 98.14% 98.68% +0.54%
===========================================
Files 65 68 +3
Lines 3988 4122 +134
===========================================
+ Hits 3914 4068 +154
+ Misses 74 54 -20
Continue to review full report at Codecov.
|
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Adding rotateable wedge
Added an isosceles triangle parametric shape
…aea/paramak into neutronics_simulations_for_components
Neutronics simulations for components
…aea/paramak into neutronics_simulations_for_components
Neutronics simulations for components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This brings a few features into the develop branch
Types of changes
What types of changes does your code introduce to the Paramak?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...