Skip to content

Develop pre review#632

Merged
shimwell merged 64 commits intodevelopfrom
develop_pre_review
Dec 16, 2020
Merged

Develop pre review#632
shimwell merged 64 commits intodevelopfrom
develop_pre_review

Conversation

@shimwell
Copy link
Collaborator

Proposed changes

This brings a few features into the develop branch

  • Removes the need for reactor objects to have a .rotation_angle when making a neutronicsModelFromReactor
  • Adds the ability to export wires (as well as solids) to a stp format
  • Adds a ShellFS parametric shape which allows a shell to be made

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

shimwell and others added 22 commits December 5, 2020 00:34
removed recreation of reactor as suggested by review
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Co-authored-by: John Billingsley <56687624+billingsley-john@users.noreply.github.com>
Co-authored-by: John Billingsley <56687624+billingsley-john@users.noreply.github.com>
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
🎉 not all reactors need rotation angles
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #632 (1176ddd) into develop (5b7ada0) will increase coverage by 0.54%.
The diff coverage is 96.70%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #632      +/-   ##
===========================================
+ Coverage    98.14%   98.68%   +0.54%     
===========================================
  Files           65       68       +3     
  Lines         3988     4122     +134     
===========================================
+ Hits          3914     4068     +154     
+ Misses          74       54      -20     
Impacted Files Coverage Δ
paramak/parametric_neutronics/neutronics_model.py 91.00% <80.76%> (ø)
paramak/parametric_components/shell_fs.py 96.15% <96.15%> (ø)
...arametric_components/rotated_isosceles_triangle.py 100.00% <100.00%> (ø)
paramak/parametric_components/rotated_trapezoid.py 100.00% <100.00%> (ø)
paramak/parametric_shapes/extruded_circle_shape.py 100.00% <100.00%> (ø)
paramak/parametric_shapes/extruded_mixed_shape.py 100.00% <100.00%> (ø)
paramak/parametric_shapes/rotate_circle_shape.py 100.00% <100.00%> (ø)
paramak/parametric_shapes/rotate_mixed_shape.py 100.00% <100.00%> (ø)
paramak/parametric_shapes/sweep_circle_shape.py 100.00% <100.00%> (ø)
paramak/parametric_shapes/sweep_mixed_shape.py 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b7ada0...1176ddd. Read the comment docs.

shimwell and others added 28 commits December 12, 2020 19:41
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Added an isosceles triangle parametric shape
…aea/paramak into neutronics_simulations_for_components
…aea/paramak into neutronics_simulations_for_components
@shimwell shimwell merged commit 75a10e7 into develop Dec 16, 2020
@shimwell shimwell deleted the develop_pre_review branch December 16, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant