Skip to content

🎉 not all reactors need rotation angles#618

Merged
shimwell merged 4 commits intodevelop_pre_reviewfrom
neutronics_model_rot_angle
Dec 11, 2020
Merged

🎉 not all reactors need rotation angles#618
shimwell merged 4 commits intodevelop_pre_reviewfrom
neutronics_model_rot_angle

Conversation

@shimwell
Copy link
Collaborator

@shimwell shimwell commented Dec 5, 2020

Proposed changes

This tiny changes allows Reactors to be build from components and shapes manually without having to set the rotation angle.

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #618 (35509b3) into develop (5b7ada0) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #618      +/-   ##
===========================================
+ Coverage    97.96%   98.21%   +0.25%     
===========================================
  Files           65       65              
  Lines         3628     3986     +358     
===========================================
+ Hits          3554     3915     +361     
+ Misses          74       71       -3     
Impacted Files Coverage Δ
...metric_neutronics/neutronics_model_from_reactor.py 85.34% <100.00%> (+1.61%) ⬆️
paramak/parametric_components/blanket_fp.py 100.00% <0.00%> (ø)
paramak/parametric_reactors/ball_reactor.py 100.00% <0.00%> (ø)
paramak/parametric_components/hollow_cube.py 100.00% <0.00%> (ø)
paramak/parametric_components/cutting_wedge.py 100.00% <0.00%> (ø)
paramak/parametric_components/vacuum_vessel.py 100.00% <0.00%> (ø)
paramak/parametric_shapes/sweep_mixed_shape.py 100.00% <0.00%> (ø)
paramak/parametric_components/tf_coil_casing.py 100.00% <0.00%> (ø)
paramak/parametric_components/tokamak_plasma.py 100.00% <0.00%> (ø)
paramak/parametric_shapes/rotate_mixed_shape.py 100.00% <0.00%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b7ada0...35509b3. Read the comment docs.

removed recreation of reactor as suggested by review
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
@shimwell shimwell changed the base branch from develop to develop_pre_review December 11, 2020 15:31
@shimwell shimwell merged commit 98ca302 into develop_pre_review Dec 11, 2020
@shimwell shimwell deleted the neutronics_model_rot_angle branch December 16, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants