🎉 not all reactors need rotation angles#618
Merged
shimwell merged 4 commits intodevelop_pre_reviewfrom Dec 11, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #618 +/- ##
===========================================
+ Coverage 97.96% 98.21% +0.25%
===========================================
Files 65 65
Lines 3628 3986 +358
===========================================
+ Hits 3554 3915 +361
+ Misses 74 71 -3
Continue to review full report at Codecov.
|
shimwell
commented
Dec 6, 2020
shimwell
commented
Dec 6, 2020
removed recreation of reactor as suggested by review
shimwell
commented
Dec 6, 2020
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This tiny changes allows Reactors to be build from components and shapes manually without having to set the rotation angle.
Types of changes
What types of changes does your code introduce to the Paramak?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...