Release v0.7.1 #200
Merged
Release v0.7.1 #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add tests to verify if forwarding headers are leaked. * only set the forwarding header when forwarding over the wire * update generated code of examples to reflect changes in thrift-gen file. * test isRemote on Router. * change the name of the forwarded header and send the keys used in forwarding instead of a static true value * Address first round of feedback. * Changed name of cached value * Add example (which doubles as a test) for self request * use a list as the return value for GetAll to enforce consistent ordering so the output can be easily glob verified * use non-naked returns because big function * Rename perserving to preserving. * add explanation how the keys are chosen * add test for multiple keys that is forwarded for * Rename HasForwardedHeader to relfect its implementation of deleting it. * fix typo
mennopruijssers
approved these changes
Dec 23, 2016
Contributor
mennopruijssers
left a comment
There was a problem hiding this comment.
two small nits, feel free to use your own judgement 👍
CHANGES.md
Outdated
| #### Header leaking | ||
|
|
||
| When applications use their incoming context blindly in an outgoing call it uses | ||
| the same headers for the outgoing call as the incoming call had, eg. incoming |
Contributor
There was a problem hiding this comment.
s/headers/tchannel headers?
CHANGES.md
Outdated
|
|
||
| With this fix the header indicating a forwarded call will not be leaked to the | ||
| application. This makes it possible for applications to use the incoming context | ||
| on a call to a sharded endpoint on their own service an correctly route the |
Contributor
There was a problem hiding this comment.
s/own/own or another ringpop service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release of ringpop 0.7.1
Lets check the changes to
CHANGES.md