feat: use generics to avoid code duplication, add DirectedEdgeFromString #100
+114
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 19253456304Details
💛 - Coveralls |
jogly
reviewed
Nov 10, 2025
Collaborator
jogly
left a comment
There was a problem hiding this comment.
Also adds DirectedEdgeFromString
h3.go
Outdated
Comment on lines
805
to
806
| // DirectedEdgeFromString returns a DirectedEdge from a string. Should call e.IsValid() to check | ||
| // if the Vertex is valid before using it. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // DirectedEdgeFromString returns a DirectedEdge from a string. Should call e.IsValid() to check | |
| // if the Vertex is valid before using it. | |
| // DirectedEdgeFromString returns a DirectedEdge from a string. Should call e.IsValid() to check | |
| // if the DirectedEdge is valid before using it. |
jogly
previously approved these changes
Nov 10, 2025
863244f to
69f1730
Compare
jogly
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.