Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate readme in CI #543

Closed
wants to merge 2 commits into from
Closed

Generate readme in CI #543

wants to merge 2 commits into from

Conversation

filiptammergard
Copy link
Collaborator

@filiptammergard filiptammergard commented Sep 4, 2022

Discussed in #542 (comment). What do you think about something like this @sw-yx and @eps1lon?

@filiptammergard filiptammergard force-pushed the gen-readme branch 8 times, most recently from 2c9fc57 to dc2e216 Compare September 4, 2022 12:28
@swyxio
Copy link
Collaborator

swyxio commented Sep 5, 2022

yup that works!

@filiptammergard filiptammergard force-pushed the gen-readme branch 3 times, most recently from 6c62839 to 2ec0080 Compare September 5, 2022 13:37
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits by GitHub actions will not themselves trigger GitHub actions. So if we have any required GitHub action in the PR checks (like formatting should be), we'll never be able to get a mergable PR.

Assuming your pink meant this was ready for review. Draft usually means "work inprogress"/cannot be merged.

@filiptammergard
Copy link
Collaborator Author

Thanks @eps1lon. My draft and ping was meant to get some early thoughts on the approach before I continued, but I see how this is probably not an approach worth exploring further. Also read through #511 again and I agree collaborating with a bot on a branch is probably not a good idea.

Do you see any middle ground here? Some other way to make it easier for contributors, while avoiding introducing other problems?

@eps1lon
Copy link
Member

eps1lon commented Sep 6, 2022

Reading the checks and fixing them is really not too much to ask. There's a error directly pointing to the step that includes the command to fix that. The rest can be guided by maintainers. But removal of the notion of "required" checks is a step backwards in other parts of the contributing story.

@filiptammergard
Copy link
Collaborator Author

I feel for those making a quick typo fix in the GitHub UI, but I guess you're right. Closing this!

@filiptammergard filiptammergard deleted the gen-readme branch September 12, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants