docs(advanced) Correct the section about discrinated types #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

eps1lon merged 1 commit into typescript-cheatsheets:master from azizhk:discrimated_union_value_check

Mar 24, 2020

Collaborator

azizhk commented Mar 24, 2020

This is just finishing the work in #183

I think this is important to mention that discriminated unions work only on value checks and not on typeof checks.


          Correct the section about discrinated types

69e230d

eps1lon changed the title ~~Correct the section about discrinated types~~ docs(advanced) Correct the section about discrinated types

eps1lon merged commit 1ab7dd2 into typescript-cheatsheets:master

Member

eps1lon commented Mar 24, 2020

@azizhk That makes a lot more sense to me. Didn't know about the typeof limitation. Thanks!

azizhk mentioned this pull request

Correct the section about discriminated union types #183

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet