docs(advancded): Fix format due to syntax error #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
requested changes
Oct 21, 2019
There was a problem hiding this comment.
Thanks for spotting this. Since we format the markdown any formatting issue is an indicator for syntax errors. I'm pretty sure this is due the missing semicolons in the last 3 lines. Could you add semicolons to the last 3 <Link /> with the old format and see if yarn format formats the code properly?
ADVANCED.md
Outdated
| return <NavLink {...props as RouterLinkProps} /> | ||
| } else { | ||
| return <a {...props as AnchorProps} /> | ||
| } | ||
| } | ||
|
|
||
| <Link<RouterLinkProps> to="/">My link</Link> // ok |
There was a problem hiding this comment.
All of these lines need a semicolon at the end. Otherwise this is invalid syntax
There was a problem hiding this comment.
You were correct, adding semicolons at the end and running yarn format helped.
|
@dkozickis Much appreciated, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes slight formatting issues in "Approach: Generic Components" making it more reabable.