Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap openssl base provider for default provider in integration tests #868

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

alexleach
Copy link
Contributor

Integration tests are failing when built against openssl 3.3.1, e.g:

+ openssl req -provider tpm2 -provider base -new -x509 -days 365 -subj '/CN=my key/' -sha256 -key /tmp/tpm_simulator_Ulvzcd/14.pem --passin pass:756dc95213a46b4249b1d3def6187339 -out /tmp/tpm_simulator_Ulvzcd/cert.pem.ec1
req: Unknown option or message digest: sha256
req: Use -help for summary.

This appears to be because neither the base nor tpm2 providers currently support the sha256 symmetric cipher algorithm, although it can be enabled in tpm2-openssl at compile time.

Using the default provider instead of base fixes tests that are currently failing.

I've submitted this patch to the Arch Linux package as well, where I later realised that it implements a commit already made here: 1b3aab9

@williamcroberts
Copy link
Member

@alexleach can you sign off your commit and I'll pull it into the next release? I am about to start the release process.

@williamcroberts williamcroberts added this to the 1.9.1 milestone Sep 5, 2024
@alexleach
Copy link
Contributor Author

@alexleach can you sign off your commit and I'll pull it into the next release? I am about to start the release process.

Done! I'd not set that up before, but that was a nice little exercise! 🙂

@williamcroberts williamcroberts self-assigned this Sep 5, 2024
@alexleach
Copy link
Contributor Author

I saw a DCO check failed as well, so I've gone through the instructions here and have now signed it off.

@williamcroberts williamcroberts merged commit 589eb3b into tpm2-software:master Sep 6, 2024
13 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants