use latest git release on new vdc/threebot deployment#3348
Merged
sameh-farouk merged 2 commits intodevelopmentfrom Nov 18, 2021
Merged
use latest git release on new vdc/threebot deployment#3348sameh-farouk merged 2 commits intodevelopmentfrom
sameh-farouk merged 2 commits intodevelopmentfrom
Conversation
AhmedHanafy725
approved these changes
Nov 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
we used to set
SDK_VERSIONenv var in threebot container to the git branch that we use to clone the repo from, in both Threebot and VDC.this PR will make this Env var default to the latest remote tag on SDK repo, so when the user deploys new threebot, VDC, or redeploy old threebot, the jssdk code in the threebot container will be checked from the latest remote release instead of the HEAD of the
developmentbranch.another change to note, that
get_latest_remote_tagfunction moved from the vdc_dashboard API controller togitmodule injs-ng, which should make sense.Caution: this PR depends on this PR and this PR in js-ng, so should be merged and a new version of js-ng should be released before we can merge this one.
Related Issues
#3349
Checklist