Merged
Conversation
dmahmouali
reviewed
Nov 14, 2021
| branch = os.environ.get("SDK_VERSION", "development") | ||
| ref = _get_latest_remote_tag | ||
| sdk_path = "/sandbox/code/github/threefoldtech/js-sdk" | ||
| cmd = f"bash jumpscale/packages/vdc_dashboard/scripts/update.sh {branch}" |
Contributor
There was a problem hiding this comment.
branch renamed to be ref as abov changes
xmonader
approved these changes
Nov 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
updaterest API url endpoint without specifying branch param will update using the latest remote tag.Changes
update.shscript can work with git tag ref too. before it was accepted only a branch name.branchparam was given with a specific branch name. before it was checked the HEAD of the development branch.Related Issues
Checklist