Disable App Extension API #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It'd be nice to be able to do this (and _our_ code does only use the app extension API), but since we're linking in Aspects (which _doesn't_ only use the app extension API), we actually can't make that guarantee. We should disable it to avoid the resulting warnings as well as any confusion that we might run into.
Contributor
|
I was considering opening a PR upstream to resolve this at the source, and leaving this as-is in the meantime. Is that something you'd be interested doing? However, if this warning is appearing in Xcode for clients of Perform, I'm 👍 on this change in the meantime. |
Contributor
|
I've come around on this — we can revisit if it becomes a problem in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'd be nice to be able to do this (and our code does only use the app
extension API), but since we're linking in Aspects (which doesn't only use
the app extension API), we actually can't make that guarantee. We should
disable it to avoid the resulting warnings as well as any confusion that we
might run into.