✨Introduce Do() operation #918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taras
approved these changes
Nov 5, 2024
Member
taras
left a comment
There was a problem hiding this comment.
How do you know that it improves performance?
Member
Author
I'm using this performance suite created by @rixtox https://github.com/cowboyd/async-benchmark/tree/effection-v4
|
Many of the Operations are comprised of a single Effect, and very often a synchronous Effect at that. There is no need to pay any of the overhead for creating a generator which has, among other things its own independent stack frame, when we could just make a simple iterator. This introduces a `Do()` operation which takes any effect and converts it automatically into an operation where it can be used anywhere. This gives us better performance and also solves the circular dependency problem inside `context.ts`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Many of the Operations are comprised of a single Effect, and very often a synchronous Effect at that. There is no need to pay any of the overhead for creating a generator when we could just make a simple iterator.
Approach
This introduces a
Do()function which takes any effect and converts it automatically into an operation (an effect iterator) so that it can be used anywhere that an operation can be used. The iterator just returns a wrapping effect that captures its result, and then the next time it is called, it returns that result. This gives us better performance and also solves the circular dependency problem insidecontext.ts