Add Feasycom BP104D, json HA compatible #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @markxroberts Could you also make the |
Contributor
|
Sorry, just realised that the windows-2019 runner ws deprecated. @markxroberts Could you rebase your PR with the current development branch, where I just submitted the new Windows runner? Or make the small change ion your PR as well. https://github.com/theengs/decoder/pull/648/files Thanks EDIT: No worries, I injected it. Thanks again for this addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added additional Feasycom device
HA doesn't like json with '-' character, so have substituted this in plugged-in for plugged_in wherever this appears in Feasycom file.
Code not compiled as only changes to json library
Checklist: