Variable "NumberOfTestsToAnalyse" is limited to the wrong boundaries #194
Merged
sagatowski merged 5 commits intotcunit:masterfrom Apr 20, 2023
Merged
Variable "NumberOfTestsToAnalyse" is limited to the wrong boundaries #194sagatowski merged 5 commits intotcunit:masterfrom
sagatowski merged 5 commits intotcunit:masterfrom
Conversation
In FB_testSuite in method AssertEquals_WORD in line 18 exchange the parameter Type_UINT with Type_WORD. Old: SetTestFailed(AssertionType := E_AssertionType.Type_UINT, New: SetTestFailed(AssertionType := E_AssertionType.Type_WORD,
This reverts commit e741511.
In FB_testSuite in method AssertEquals_WORD in line 18 exchange the parameter Type_UINT with Type_WORD. Old: SetTestFailed(AssertionType := E_AssertionType.Type_UINT, New: SetTestFailed(AssertionType := E_AssertionType.Type_WORD,
…g boundaries Correction of the definition of variable "NumberOfTestsToAnalyse" in the two blocks "FB_TestResults" (one time) and "FB_TestSuite" (five times). A wrong limit was used. Old: NumberOfTestsToAnalyse : UINT(1..GVL_Param_TcUnit.MaxNumberOfTestSuites); New: NumberOfTestsToAnalyse : UINT(1..GVL_Param_TcUnit.MaxNumberOfTestsForEachTestSuite);
Member
|
Sorry for late merge. Thanks for your contribution @JoergWitt! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request solves #187.
Correction of the definition of variable
NumberOfTestsToAnalysein the two blocksFB_TestResults(one time) andFB_TestSuite(five times). A wrong limit was used.Old:
NumberOfTestsToAnalyse : UINT(1..GVL_Param_TcUnit.MaxNumberOfTestSuites);New:
NumberOfTestsToAnalyse : UINT(1..GVL_Param_TcUnit.MaxNumberOfTestsForEachTestSuite);