Removed duplicate code and some perfomance optimizations#166
Merged
sagatowski merged 2 commits intotcunit:masterfrom Jan 7, 2022
Merged
Removed duplicate code and some perfomance optimizations#166sagatowski merged 2 commits intotcunit:masterfrom
sagatowski merged 2 commits intotcunit:masterfrom
Conversation
Some performance optimizations
Member
|
Thanks for this PR. I'll try to look at it during the weekend. |
Member
|
@oswin02 Merged. Took a little longer than "just a weekend". Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumberOfTestsToAnalyze calculation moved in a method to remove duplicate code;
Deleted some needless IF statements surrounding the for loops (when NumberOfTestsToAnalyse is 0, the FOR loop is not executed);
Return immediately from AreAllTestsFinished when one unfinished test was found;