proxy settings #241
Merged
proxy settings #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement --proxy, --no-proxy options implement but not tested --use-certificate option
haven't tested the use_certificate option properly yet, need a server that supports it
anyoung-tableau
requested changes
Mar 17, 2023
tabcmd/commands/auth/session.py
Outdated
| "Connection args: server {}, site {}, proxy {}, cert {}".format( | ||
| self.server_url, self.site_name, self.proxy, self.certificate | ||
| "Connection args: server {}, site {}, proxy {}/no-proxy {}, cert {}".format( | ||
| self.server_url, self.site_name, self.proxy, self.certificate, self.no_proxy |
Contributor
There was a problem hiding this comment.
Looks like self.no_proxy needs to come before self.certificate
tabcmd/commands/auth/session.py
Outdated
| if self.username: | ||
| self.logger.info("===== Username: {}".format(self.username)) | ||
| if self.certificate: | ||
| self.logger.info("===== Certificate: {}".format(self.proxy)) |
Contributor
There was a problem hiding this comment.
.format(self.certificate)
Merged
jacalata
added a commit
that referenced
this pull request
Jul 28, 2023
Fixes, code enhancements * remove lowercase call while parsing csv for adding users * set user agent (#219) * Add and clean up logging, always include version in logs (#234, #224) * Encoding filter values to handle spaces and special chars in filters (#225) * replace polling code with library call * readme updates (#235) * Read and warn when user sets thumbnail options. (including 'not yet implemented' message for --thumbnail-group) * freeze tsc dependency (#248) New functionality * added new --filter option to pass in un-encoded value for simpler input * Add --url, --include-all/--embedded-datasources for create/refresh/delete extract commands (#227) * Add new command for listing content on the site (#230) * Implement publishing options overwrite/append/replace arguments (including not-yet-implemented message for --replace) (#236) * implement --proxy, --no-proxy, --use-certificate option (#241) * add --token-file option (#243) --------- Co-authored-by: Bhuvnesh Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to set proxy information for tabcmd, or to unset it (--no-proxy)
Also allow the user to set a certificate, but this feature should be considered beta in this release.