Skip to content

Jac/parse publish options #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jacalata merged 7 commits into from
Mar 11, 2023
Merged

Jac/parse publish options #236

jacalata merged 7 commits into from
Mar 11, 2023

Conversation

@jacalata
Copy link
Contributor

@jacalata jacalata commented Mar 9, 2023 •
edited
Loading

Added --replace, --append and --overwrite options for publishing to the parser, but they are not yet all implemented in the API and tsc.
Also gave more detailed help messages for extract encryption and thumbnail publishing options.

example for 'append':
c:\dev\tabcmd2>python -m tabcmd publish tests\assets\SampleDS.tds --name my-second-drawing --append
....
Succeeded
Publishing ''tests\assets\SampleDS.tds'' to the server. This could take several minutes...
400054: Bad Request
Only a '.hyper' or '.tde' file can be appended to a datasource.
Exiting...

jacalata added 5 commits March 1, 2023 17:24
@jacalata
implement thumbnail options.
510c2c3 
including 'not yet implemented' message for --thumbnail-group
@jacalata
Implement overwrite/append/replace
151a90a 
- tweaked logic of which value can apply
- clarified help content
- added tests for all valid publish command options

Not tested.
@jacalata
edit encryption help
004b546
@jacalata
format
ee10156
@jacalata
lots of error log cleanup
3965e1d 
better stacktrace, less repetition
@github-actions
Copy link

github-actions bot commented Mar 9, 2023 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
tabcmd
   __main__.py888 0%
   tabcmd.py151515 0%
   version.py633 50%
tabcmd/commands
   commands.py101010 0%
   constants.py721212 83%
   server.py1262626 79%
tabcmd/commands/auth
   session.py3444747 86%
tabcmd/commands/datasources_and_workbooks
   datasources_and_workbooks_command.py1171313 89%
   delete_command.py601616 73%
   export_command.py1252727 78%
   get_url_command.py1906262 67%
   publish_command.py842828 67%
   runschedule_command.py2177 67%
tabcmd/commands/extracts
   create_extracts_command.py4288 81%
   decrypt_extracts_command.py2722 93%
   delete_extracts_command.py3766 84%
   encrypt_extracts_command.py2722 93%
   extracts.py2022 90%
   reencrypt_extracts_command.py2722 93%
   refresh_extracts_command.py481313 73%
tabcmd/commands/group
   create_group_command.py2955 83%
   delete_group_command.py2722 93%
tabcmd/commands/project
   create_project_command.py4688 83%
   delete_project_command.py3544 89%
   publish_samples_command.py2844 86%
tabcmd/commands/site
   create_site_command.py3455 85%
   delete_site_command.py2822 93%
   edit_site_command.py3822 95%
   list_command.py432525 42%
   list_sites_command.py3022 93%
tabcmd/commands/user
   create_site_users.py571010 82%
   create_users_command.py601010 83%
   delete_site_users_command.py4355 88%
   user_data.py2203030 86%
tabcmd/execution
   _version.py222 0%
   global_options.py1442424 83%
   localize.py6788 88%
   logger_config.py4266 86%
   tabcmd_controller.py3344 88%
TOTAL258946782% 

@jacalata jacalata force-pushed the jac/publish-options branch from 0254a4c to 61568c5 Compare March 10, 2023 21:33
@jacalata
mypy
248b08d 
hmm, this didn't complain locally.
@jacalata jacalata force-pushed the jac/publish-options branch from 61568c5 to 248b08d Compare March 10, 2023 21:35
anyoung-tableau
anyoung-tableau approved these changes Mar 10, 2023
View reviewed changes
@jacalata jacalata merged commit 80cb757 into development Mar 11, 2023
@jacalata jacalata deleted the jac/publish-options branch March 11, 2023 22:21
This was referenced Jul 27, 2023
Merged
Open
jacalata added a commit that referenced this pull request Jul 28, 2023
@jacalata @bhuvneshdev
Push code for 2.12 (#259)
4e57e9d 
Fixes, code enhancements
* remove lowercase call while parsing csv for adding users
* set user agent (#219)
* Add and clean up logging, always include version in logs (#234, #224)
* Encoding filter values to handle spaces and special chars in filters  (#225)
* replace polling code with library call
* readme updates (#235)
* Read and warn when user sets thumbnail options. (including 'not yet implemented' message for --thumbnail-group)
* freeze tsc dependency (#248)

New functionality
* added new --filter option to pass in un-encoded value for simpler input
* Add --url, --include-all/--embedded-datasources for create/refresh/delete extract commands (#227)
* Add new command for listing content on the site (#230)
* Implement publishing options overwrite/append/replace arguments (including not-yet-implemented message for --replace) (#236)
* implement --proxy, --no-proxy,  --use-certificate option  (#241)
* add --token-file option (#243)

---------

Co-authored-by: Bhuvnesh Singh <[email protected]>
jacalata added a commit that referenced this pull request May 6, 2024
@jacalata
Jac/parse publish options (#236)
6da7858 
* implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group)
* Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace)
* clarified help content for extract-encryption and some other not-implemented options
* added tests for all valid publish command options
* error log cleanup: better stacktrace, less repetition
jacalata added a commit that referenced this pull request Jun 14, 2024
@jacalata
Jac/parse publish options (#236)
5707047 
* implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group)
* Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace)
* clarified help content for extract-encryption and some other not-implemented options
* added tests for all valid publish command options
* error log cleanup: better stacktrace, less repetition
jacalata added a commit that referenced this pull request Aug 1, 2024
@jacalata
Jac/parse publish options (#236)
5332384 
* implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group)
* Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace)
* clarified help content for extract-encryption and some other not-implemented options
* added tests for all valid publish command options
* error log cleanup: better stacktrace, less repetition
jacalata added a commit that referenced this pull request Jan 10, 2025
@jacalata
Jac/parse publish options (#236)
914cded 
* implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group)
* Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace)
* clarified help content for extract-encryption and some other not-implemented options
* added tests for all valid publish command options
* error log cleanup: better stacktrace, less repetition
jacalata added a commit that referenced this pull request Jan 10, 2025
@jacalata
Jac/parse publish options (#236)
299c4de 
* implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group)
* Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace)
* clarified help content for extract-encryption and some other not-implemented options
* added tests for all valid publish command options
* error log cleanup: better stacktrace, less repetition
jacalata added a commit that referenced this pull request Jan 10, 2025
@jacalata
Jac/parse publish options (#236)
1a166fe 
* implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group)
* Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace)
* clarified help content for extract-encryption and some other not-implemented options
* added tests for all valid publish command options
* error log cleanup: better stacktrace, less repetition
jacalata added a commit that referenced this pull request Jan 10, 2025
@jacalata
Jac/parse publish options (#236)
3c880b5 
* implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group)
* Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace)
* clarified help content for extract-encryption and some other not-implemented options
* added tests for all valid publish command options
* error log cleanup: better stacktrace, less repetition

Jac/parse publish options (#236)

* implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group)
* Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace)
* clarified help content for extract-encryption and some other not-implemented options
* added tests for all valid publish command options
* error log cleanup: better stacktrace, less repetition

Jac/parse publish options (#236)

* implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group)
* Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace)
* clarified help content for extract-encryption and some other not-implemented options
* added tests for all valid publish command options
* error log cleanup: better stacktrace, less repetition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anyoung-tableau anyoung-tableau anyoung-tableau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacalata @anyoung-tableau