Skip to content

Grading PR [DO NOT MERGE]#42

Open
martypdx wants to merge 2 commits intotableau-app:masterfrom
martypdx:master
Open

Grading PR [DO NOT MERGE]#42
martypdx wants to merge 2 commits intotableau-app:masterfrom
martypdx:master

Conversation

@martypdx
Copy link

Comments and feedback, not for merging.

  • Reducers look good. Missing LOADING and ERROR actions for most server API actions.
  • Nice use of styled components and overall React and Redux looks idiomatic :)
  • Too bad you couldn't get to having avatars, or at the least use gravatar.
  • Don't hardcode image url's in components. Import images, or even with placeholders externalize them from the component, images.THUMBNAIL_COVER

@martypdx martypdx changed the title initial grading commit [DO NOT MERGE] Grading PR [DO NOT MERGE] Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant