Re-write of Page Creation #5386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
book/bundles.rst
Outdated
There was a problem hiding this comment.
Instead of saying "an app is made of bundles defined in registerBundles()`, what about explaining it in reverse: "Bundles used in your applications must be enabled by registering them in the registerBundles() method."
|
@weaverryan this proposal is absolutely brilliant! I couldn't like it more. Amazing! |
|
Thanks Javier (and fast!). I've just used all of your suggestions :). |
book/bundles.rst
Outdated
There was a problem hiding this comment.
- has to be = and ~ has to be - in this article's titles.
book/page_creation.rst
Outdated
The following gist shows all of the sections that were removed and not replaced somewhere else: https://gist.github.com/weaverryan/252f02b3028888b3f5df Some big parts were moved to 2 new chapters - bundles and configuration - which will also need to be re-read.
75a61f9 to
be87cff
Compare
weaverryan
added a commit
that referenced
this pull request
Jun 19, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Re-write of Page Creation | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | n/a Hi guys! Woh! I'm super excited about this - another step to making Symfony more and more accessible to everyone. The "page creation" chapter should be people's entry point to Symfony (quick tour should be more for advertising I think). But, when I re-read this chapter - it was terrible (I probably wrote most of it) - way too many long explanations when someone is first starting. It also is one of the last spots to use AcmeDemoBundle. The goal: let someone read for 10 minutes, get some success/momentum, and link to where to go next (and some other interesting spots, without overwhelming). A lot was moved to 2 new chapters - bundles and configuration - which I'll re-read soon in the same way. Right now - `bundles.rst` and `configuration.rst` are verbatim of what they were before. So, we don't need to review these, other than to make sure they don't have an abrupt start or end (since they were just sections in the middle of `page_creation.rst` before. Some stuff was just removed. A list is here: https://gist.github.com/weaverryan/252f02b3028888b3f5df Thanks guys! Commits ------- be87cff Remoing link to now-gone web section 31c76c6 Fixes thanks to Wouter! bc33dad removing reference that I removed 53819ad removing duplicate reference 01f52fd Lots of updates thanks to @javiereguiluz! 393e8d8 adding missing reference aa3cc95 Proofread! 6a66868 Complete rewrite of the page creation chapter to be much shorter 6b6cbc0 WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
Woh! I'm super excited about this - another step to making Symfony more and more accessible to everyone. The "page creation" chapter should be people's entry point to Symfony (quick tour should be more for advertising I think).
But, when I re-read this chapter - it was terrible (I probably wrote most of it) - way too many long explanations when someone is first starting. It also is one of the last spots to use AcmeDemoBundle.
The goal: let someone read for 10 minutes, get some success/momentum, and link to where to go next (and some other interesting spots, without overwhelming).
A lot was moved to 2 new chapters - bundles and configuration - which I'll re-read soon in the same way.
Right now -
bundles.rstandconfiguration.rstare verbatim of what they were before. So, we don't need to review these, other than to make sure they don't have an abrupt start or end (since they were just sections in the middle ofpage_creation.rstbefore.Some stuff was just removed. A list is here: https://gist.github.com/weaverryan/252f02b3028888b3f5df
Thanks guys!