Update routing.rst #4586
Closed
Update routing.rst #4586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add route name "blog_show" in first example
| @@ -45,7 +45,7 @@ The route is simple: | |||
| class BlogController extends Controller | |||
| { | |||
| /** | |||
| * @Route("/blog/{slug}") | |||
| * @Route("/blog/{slug}" name="blog_show ") | |||
There was a problem hiding this comment.
There is a trailing space in the route name.
There was a problem hiding this comment.
and the comma between the two arguments are missing.
|
@guangle I wish you a happy new year! :) Will you be able to update the pull request? |
weaverryan
added a commit
that referenced
this pull request
Mar 14, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Finish #4586: Update routing.rst Finished #4586 Original PR description: > add route name "blog_show" in first example | Q | A | --- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - Commits ------- c75455f Update routing.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add route name "blog_show" in first example