[BestPractices Removing micro-optimization note about @Template #4464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One of the (few) great things about |
| @@ -76,20 +76,15 @@ Template Configuration | |||
| Don't use the ``@Template()`` annotation to configure the template used by | |||
| the controller. | |||
|
|
|||
| The ``@Template`` annotation is useful, but also involves some magic. For | |||
| that reason, we don't recommend using it. | |||
| The ``@Template`` annotation is useful, but also involves some magic. We | |||
There was a problem hiding this comment.
You avoided the first person perspective in the rest of the Best Practices, didn't you?
There was a problem hiding this comment.
Actually, this is one spot where we use it liberally - as in "we recommend..."
|
@javiereguiluz I've never understood the point of the guessing of the template suffix, but it sounds like you may have a use-case. For me, I would never use a template to print JSON or XML, so I've never found this useful. Is there some good case for this? |
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
I think that a small performance gain is not a great reason to recommend something. And really, this was not the most important reason for recommending against
@Template. I think it's clearer to focus on the real reason, and not get into performance (we could argue against using any feature because of performance).Thanks!