-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Adds documentation for the new ISSN validator #2539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Acme\JournalBundle\Entity\Journal: | ||
properties: | ||
issn: | ||
- Issn: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Issn: ~
@ricardclau I've added a link to the wikipedia article for ISSN and a Waiting for more feedback. |
You should surround the text you want to be the link with ` and use that text at the bottom of the rst document. Otherwise, as far as I know, the link will not work as expected. As this is easier to see than to explain with words, please check https://raw.github.com/symfony/symfony-docs/master/reference/constraints/Luhn.rst Notice that there is a link at the bottom but when the html is generated, link appears at the text written at line 7. There should be something like this: bla bla bla and at the end of the document .. _ |
Forgive me. I'm pretty new to the rst format. |
The validator will allow non hyphenated ISSN values by default. When switching | ||
this to ``true``, the validator requires an hyphenathed ISSN value. | ||
|
||
.. _`ISSN`: http://en.wikipedia.org/wiki/Issn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a new line after the last line to avoid bad diffs if someone adds another link in this article
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
No worries! I always have to double check on rst and even with it @wouterj corrects me most of the times ;) Thanks for adding the link! |
If you have no new comments, I will squash the commit. Any last minute comment? |
No, I'm 👍 for this now. |
Squashed! Thanks for your support with my first documentation contribution. |
Adds documentation for the new ISSN validator
Hi Antonio! Very nice work and tweaks on this entry - it was basically perfect! I only had very minor tweaks at sha: 5821250 Thanks for your contribution! |
Reference document for the new ISSN validator. Please, review it as my English is not very good.