Skip to content

[Routing] Document _query parameter for URL generation #21119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 7.4
Choose a base branch
from

Conversation

mttsch
Copy link
Contributor

@mttsch mttsch commented Jun 22, 2025

Fix #21055


.. versionadded:: 7.4

The ``_query`` parameter was introduced in Symfony 7.4.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps adds that its an array ?
Or give an example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other parameters are documented with the same level of detail, thus I wanted to keep it consistent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it, also down below there is example for _locale and _format which are "dev oriented" variables
the _controller and _fragment are more "internal oriented"

this new param _query seems more the first to me, for devs so I really think giving a small example can be valuable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will wait for some of the maintainers to comment on this, to avoid adding the example and then later on it requesting to be removed. (_fragment is also for "external" use to set the URL hash.)

@OskarStark OskarStark changed the title [Routing] Document _query parameter for URL generation [Routing] Document _query parameter for URL generation Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants