Remove paragraph about doctrine mapping override #14152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I would suggest to remove the paragraph about mapping override because it doesn't work in all cases.
I read the related PR (#10053) and the issue (#7076) which motivated it. The example in the issue works only because
auto_mapping
is set totrue
(auto_mapping: true
allows to find definitions in `Resources/config/doctrine/*.orm.{xml, yml, php} of all the bundles even if nothing is declared in the bundles).From the POV of the bundle , it's IMHO not a good practice to rely on app
auto_mapping
configuration (the trend for sf4 and sf5 is to rely on configurations over conventions).So when bundle mapping rely on the dedicated compiler pass (example here) and not on
auto_mapping
app configuration , the mapping definition file in the compiler pass (from the bundle) overrides the mapping definition file defined in the application.