Fixes security authentication provider cookbook article #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icle in favor of adding the extension in the Bundle.
|
Hi Brent old friend! So really nice job identifying the 2.1 changes, here's how this needs to work:
The easiest way to do this might be to make (1) first, let me merge it in, let me merge 2.0 to master, and then do the second one based off of the new master. If you can strip off the 2.1 commit from this PR, then I can get that rolling. Thanks! |
|
I created this PR for 1, and will commit 2 as soon as that is merged into the master branch Next time I'm submitting a PR to Leanna. I bet she would be nicer :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses this issue:
#1033
This fixes the listener to always return a 403 when the request is not WSSE. This was previously cause for much confusion.
Also, it seems the
security_factoriesconfiguration key is no longer valid, so we are now initializing the security factory as part of theAcmeDemoBundle. This is how it's done in core, but if there's a better way I will change it.The diffs are confusing as hell for some reason. The listener is changed now so the logic is wrapped in a conditional, and the security_factories portion is replaced by a code sample from AcmeDemoBundle.
Let me know if you have any questions!