-
-
Notifications
You must be signed in to change notification settings - Fork 145
chore: bring over tutorial (without content) #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
copied almost verbatim, replaces the old tutorial. stuff in lib is organized slightly different to the learn.svelte repo (because we now have other stuff in the lib folder, too).
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Rich-Harris could you check if web container boots up correctly for you locally? If so I'm tempted to merge this to keep the diff somewhat under control, and then iteratively work towards getting the app actually building (with the content etc) |
Yeah same for me, it gets stuck in the ready state, the iframe never starts firing the messages to the parent window which the output tab uses to remove the loading state. Something inside the iframe seems to not be set up correctly |
resolved the mystery, the stub I put in was incomplete/wrong. Works now. Looking into what else I need to bring over now. |
Nice! I was thinking we'd put the content in the same place as everything else, so we can have a unified approach to search etc (obviously it'll involve some finagling to get the actual code bits of the exercises working). I'll open a PR to move the content to the root now |
(the existing content, I mean) |
yeah sounds good, I'll not do the content stuff in here. I'll see if I can bring over the playwright tests and then merge this |
ok playwright tests are so unbearably slow because of the webcontainer bootup that I don't think it's worth it bringing them over now, they will just fail all the time. We should investigate that separately. |
Copied over the technical side of things almost verbatim, replaces the old tutorial. stuff in lib is organized slightly different to the learn.svelte repo (because we now have other stuff in the lib folder, too).
The webcontainers don't load for me yet locally, not sure why.
Other questions:
middleware.js
in the learn.svelte repo, do we need to bring that over? What does it do? Does it need to be at the root of the repo or the app project (hopefully the latter)?vercel.json
Todos:
static
folder