Skip to content

chore: bring over tutorial (without content) #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 12, 2024
Merged

chore: bring over tutorial (without content) #9

merged 8 commits into from
Jun 12, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Jun 11, 2024

Copied over the technical side of things almost verbatim, replaces the old tutorial. stuff in lib is organized slightly different to the learn.svelte repo (because we now have other stuff in the lib folder, too).

The webcontainers don't load for me yet locally, not sure why.

Other questions:

  • there's middleware.js in the learn.svelte repo, do we need to bring that over? What does it do? Does it need to be at the root of the repo or the app project (hopefully the latter)?
  • same for vercel.json

Todos:

  • playwright tests need to be brought over (only makes sense once the app actually builds)
  • check if we need something from the static folder

copied almost verbatim, replaces the old tutorial. stuff in lib is organized slightly different to the learn.svelte repo (because we now have other stuff in the lib folder, too).
Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnisite ❌ Failed (Inspect) Jun 12, 2024 1:39pm

@dummdidumm dummdidumm changed the title chore: bring over tutorial chore: bring over tutorial (without content) Jun 11, 2024
@dummdidumm
Copy link
Member Author

@Rich-Harris could you check if web container boots up correctly for you locally? If so I'm tempted to merge this to keep the diff somewhat under control, and then iteratively work towards getting the app actually building (with the content etc)

@Rich-Harris
Copy link
Member

If I copy over the common.zip and unzip.cjs files then I get as far as this:

image

Not sure yet what's missing for it to start the app

@dummdidumm
Copy link
Member Author

Yeah same for me, it gets stuck in the ready state, the iframe never starts firing the messages to the parent window which the output tab uses to remove the loading state. Something inside the iframe seems to not be set up correctly

@dummdidumm
Copy link
Member Author

dummdidumm commented Jun 12, 2024

resolved the mystery, the stub I put in was incomplete/wrong. Works now. Looking into what else I need to bring over now.

@Rich-Harris
Copy link
Member

Nice! I was thinking we'd put the content in the same place as everything else, so we can have a unified approach to search etc (obviously it'll involve some finagling to get the actual code bits of the exercises working). I'll open a PR to move the content to the root now

@Rich-Harris
Copy link
Member

(the existing content, I mean)

@dummdidumm
Copy link
Member Author

yeah sounds good, I'll not do the content stuff in here. I'll see if I can bring over the playwright tests and then merge this

@dummdidumm
Copy link
Member Author

ok playwright tests are so unbearably slow because of the webcontainer bootup that I don't think it's worth it bringing them over now, they will just fail all the time. We should investigate that separately.

@dummdidumm dummdidumm merged commit a5bf317 into main Jun 12, 2024
1 of 3 checks passed
@dummdidumm dummdidumm deleted the tutorial branch June 12, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants