Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: statically analyse universal pages and layouts #13669

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Apr 3, 2025

closes #12580

Based off @benmccann 's suggestion, this PR uses static analysis to retrieve literal values from the universal module without importing it on the server. Instead, we only import the module on the server if a non-literal value is accessed such as the load function or a value that can only be determined at runtime. This allows developers to use browser APIs in their universal pages and layouts if they have export const ssr = false.

It also logs the reason we load a module if it fails to load (e.g., trying to access export X or not being able to statically analyse all exports). The only exception is during build and a module re-exports all named exports from another module because we can't use top-level await to dynamically import the module and catch the import error.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Apr 3, 2025

🦋 Changeset detected

Latest commit: 9de8f40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@eltigerchino eltigerchino marked this pull request as ready for review April 8, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid loading +page.js/+layout.js files on server in SPA mode
1 participant