Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: avoid using titles that have _ in them #13660

Merged
merged 2 commits into from
Apr 2, 2025
Merged

Conversation

eltigerchino
Copy link
Member

This PR fixes the Cloudflare docs page changes from #13634

Having a title such as _headers` and `_redirects causes svelte.dev to render a part of the title as italic and discards the _ character. This causes the sub-menu link for that section to be rendered incorrectly so SvelteKit reports a missing ID.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Apr 2, 2025

⚠️ No Changeset found

Latest commit: 48b92fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eltigerchino eltigerchino added documentation Improvements or additions to documentation pkg:adapter-cloudflare labels Apr 2, 2025
@svelte-docs-bot
Copy link

@benmccann
Copy link
Member

Looks like we both saw this around the same time. I pushed something I hope will fix it here: 12925fb

If mine doesn't work then we may have to try this one

@benmccann benmccann merged commit 564500b into main Apr 2, 2025
16 checks passed
@benmccann benmccann deleted the eltigerchino-patch-1 branch April 2, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pkg:adapter-cloudflare
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants