Fix retaining cycle caused by timer on SuperpoweredIOSAudioIO #533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Description
NSTimer
todispatch_source_t
objectComment
On a personal project I notice that instances of
SuperpoweredIOSAudioIO
could never be deallocated because of a strong reference kept by NSTimer.Dealloc
would never be called.I changed the implementation of the stopTimer (originally a
NSTimer
) to a be adispatch_source_t
object. This way no strong reference to self was kept.It was a simple fix, that maintains the same intended functionality (calling
everySecond
method every second while SuperpoweredIOSAudioIO exists), with the benefit of preventing this memory leak.Virtually no impact on compatibility
Also this change doesn't impact on compatibility.
dispatch_source_t
is available on:iOS 4.0+, macOS 10.6+, tvOS 9.0+, watchOS 2.0+