WIP: Liteprinter #4679

atdotde · 2026-01-11T16:00:48Z

These are the first steps using QLiteHtml for printing logbook pages in Qt6.

State of affairs: It prints logbook pages but all sizes are wrong. But I think it looks promising.
It does not try to really parse the html (which was a show stopper in the past) but simply uses a regex to do the
div class="diveProfile" to img replacement. This could also be done with xslt but not by me.

It requires the latest version of litehtml which contains a fix for a bug that would overlap tables. Maybe @dirkhh could update his QLiteHtml branch.

Describe the pull request:

Pull request long description:

Changes made:

Related issues:

Additional information:

Documentation change:

Mentions:

Signed-off-by: Robert C. Helling <[email protected]>

dirkhh · 2026-01-11T16:04:03Z

I'm traveling (actually diving, so not complaining), it may take be a couple of days before I get to this.

github-actions · 2026-01-11T16:12:58Z

Artifacts:
Subsurface-Android-6.0.5514-patch.4.pull-request.liteprinter
WARNING: Use at your own risk.

dirkhh · 2026-01-11T17:03:03Z

OK, I didn't review the code, and I didn't update your PR, but if you apply this:

diff --git a/scripts/get-dep-lib.sh b/scripts/get-dep-lib.sh
index 731a875ae..f5ed96326 100755
--- a/scripts/get-dep-lib.sh
+++ b/scripts/get-dep-lib.sh
@@ -19,7 +19,7 @@ CURRENT_MDBTOOLS="v1.0.0"
 CURRENT_QT_ANDROID_CMAKE="master"
 CURRENT_LIBMTP="v1.1.22"
 CURRENT_LIBRAW="0.21.4"
-CURRENT_QLITEHTML="b8f9096eae730ec9464b24874e4e6312144aa9ce"
+CURRENT_QLITEHTML="865c9bb2eb9dcef6a0fed5bc5c4a9ab4bd777f74"
 
 croak() {
        echo $@

you should get a qlitehtml library with the latest litehtml code.

dirkhh

A few comments, mostly pointless.
This looks like a really promising start, Robert.
Thanks for working on this!

dirkhh · 2026-01-11T17:04:44Z

desktop-widgets/printer.cpp

+#if defined(USE_WEBKIT)
 	webView(new QWebView),
-	printOptions(printOptions),
-	templateOptions(templateOptions),


just doing a quick read-through before heading to the harbor...
since you #ifdef that code, why are you removing those two lines? Or is that an unrelated change?

dirkhh · 2026-01-11T17:05:30Z

desktop-widgets/printer.cpp

+# include <qlitehtmlwidget.h>
 #elif defined(USE_WEBKIT)
-# include <QtWebKitWidgetst>
+#include <QtWebKitWidgetst>


odd whitespace change? either we do the space indent, or we don't?

dirkhh · 2026-01-11T17:06:13Z

desktop-widgets/printer.cpp

+	templateOptions(templateOptions),
 	printMode(printMode),
 	singleDive(singleDive),
+	printOptions(printOptions),


ah, I think this explains what my first comment was about... but then it should happen at the same time, in the same commit, no?

dirkhh · 2026-01-11T17:07:47Z

desktop-widgets/printer.cpp

 			webView->setHtml(t.generateStatistics());
+#else
+			;
+#endif


not my favorite way to express this -- why not just #ifdef the whole if/else-if?
What am I missing?

dirkhh · 2026-01-11T17:09:29Z

desktop-widgets/printer.cpp

 		return QByteArray();
 	});
-	previewWidget.setGeometry(QRect(0,0,1600,1000));
+	previewWidget.setGeometry(QRect(0,0,1200,1000));


frankly, neither of these hard coded values is the right thing to do. Something-something based on the current window size? But that's me just being annoying, this is good for now

dirkhh · 2026-01-11T17:10:09Z

desktop-widgets/printer.cpp

-	previewWidget.setHtml(content);
+	// QFile file("/Users/Helling_1/logbuch.html");
+	// if (!file.open(QIODevice::ReadOnly | QIODevice::Text))
+	// 	return;


😁
maybe not in the final version?

dirkhh · 2026-01-11T17:11:46Z

desktop-widgets/printer.cpp

 	// previewWidget.setHtml(in.readAll());

+	QString repl = QString("<img height=\"30%\" width=\"30%\" src=\"file:///%1/dive_\\1.png\">").arg(printDir.path());
+	content.replace(QRegularExpression("<div\\s+class=\"diveProfile\"\\s+id=\"dive_([^\"]*)\"\\s*>\\s*</div>"), repl);


brute force, but not wrong. And better than making it crazy complex and bringing in more dependencies, maybe.

I can probably provide some XSLT to do this in a more robust way, adding support for things like self-closing elements, or additional properties on the element itself.

See atdotde#5 for a way to do the html transformation with XSLT.

dirkhh · 2026-01-11T17:14:12Z

clearly missing a widget in order to build...

mikeller

It looks like this is pulling in some likely unwanted libdivecomputer changes - you probably need to make sure that libdivecomputer is on the latest version of Subsurface-DS9 in your branch.

Signed-off-by: Robert C. Helling <[email protected]>

github-actions · 2026-01-15T21:58:25Z

Artifacts:
Subsurface-Linux-AppImage-6.0.5514-patch.5.pull-request.liteprinter
WARNING: Use at your own risk.

github-actions · 2026-01-15T22:01:57Z

Artifacts:
Subsurface-MacOS-arm64-qt-6.8.3-6.0.5514-patch.5.pull-request.liteprinter
Subsurface-MacOS-x86_64-qt-5-6.0.5514-patch.5.pull-request.liteprinter
Subsurface-MacOS-x86_64-qt-6.8.3-6.0.5514-patch.5.pull-request.liteprinter
WARNING: Use at your own risk.

github-actions · 2026-01-15T22:02:06Z

Artifacts:
Subsurface-Android-6.0.5514-patch.5.pull-request.liteprinter
WARNING: Use at your own risk.

github-actions · 2026-01-15T22:06:12Z

Artifacts:
Subsurface-Windows-6.0.5514-patch.5.pull-request.liteprinter
WARNING: Use at your own risk.

bstoeger · 2026-01-24T18:53:54Z

If QLiteHtml is supported on all platforms, I would suggest replacing the old code instead of adding ifdef-ery complexity.

bstoeger · 2026-01-24T18:59:23Z

desktop-widgets/printer.cpp

+	previewWidget.setStyleSheet(QString(
+					  "QLiteHtmlWidget"
+					  " { selection-background-color: %1; selection-color: %2; }")
+					  .arg(colorBack).arg(colorText));


Does .arg(colorBack, colorText) not work?

Yeah, this is not performance sensitive, but still...

atdotde added 4 commits January 11, 2026 12:15

Turning on the printing again

bb2603e

Signed-off-by: Robert C. Helling <[email protected]>

Open a widget and show the log for printing

e02abcc

Signed-off-by: Robert C. Helling <[email protected]>

Add actual printing

80122f1

Signed-off-by: Robert C. Helling <[email protected]>

Habemus profile

bc52078

Signed-off-by: Robert C. Helling <[email protected]>

atdotde requested a review from dirkhh January 11, 2026 16:00

dirkhh reviewed Jan 11, 2026

View reviewed changes

mikeller reviewed Jan 11, 2026

View reviewed changes

restore old printing

d180dc1

Signed-off-by: Robert C. Helling <[email protected]>

bstoeger reviewed Jan 24, 2026

View reviewed changes

Uh oh!

WIP: Liteprinter #4679

Are you sure you want to change the base?

WIP: Liteprinter #4679

Conversation

atdotde commented Jan 11, 2026

Describe the pull request:

Pull request long description:

Changes made:

Related issues:

Additional information:

Documentation change:

Mentions:

Uh oh!

dirkhh commented Jan 11, 2026

Uh oh!

github-actions bot commented Jan 11, 2026

Uh oh!

dirkhh commented Jan 11, 2026

Uh oh!

dirkhh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dirkhh commented Jan 11, 2026

Uh oh!

mikeller left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

bstoeger commented Jan 24, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants