Add freedive-specific details #4236
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Divide the dive details into dips. * Add new weight type `neck`. * Display dip details in `Information` tab. * Add `Best dip` as key to dive list. Signed-off-by: Steffen Jaeckel <[email protected]>
1 task
Collaborator
|
@sjaeckel: Are you still interested in this? Please use |
Author
|
Thanks for the pointer! I'll rework my patches as soon as I have the time. |
|
This pull request has merge conflicts, please resolve them in order to make this pull request ready for review / merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
Do some basic analysis on a dive if it's a freedive and split the parts up into the different dips.
Changes made:
neck.Informationtab.Best dipas key to dive list.Related issues:
Additional information:
That's how it currently looks for me.
The buttons don't have functionality yet, but will move the ruler in the profile view.
Release note:
Documentation change:
Mentions: