add predecessor run id to transcriptic launch command #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samjoch
previously approved these changes
Jul 12, 2021
xiliuStrateos
suggested changes
Jul 15, 2021
Contributor
|
@joshhacksthings This PR lgtm, do you have any other comments? |
Contributor
|
@aaronstrateos you're good to merge once you address Xi's comment above! No need for my approval |
xiliuStrateos
approved these changes
Jul 16, 2021
EribertoLopez
pushed a commit
that referenced
this pull request
Nov 9, 2021
* add predecessor run id to transcriptic launch command, update version and changelog * lint * lint * remove print to standard out and update submit_run_request with predecessor id arg * changelog * lint * whitespace * add predecessor id to payload directly * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If predecessor id passed to launch command, it will print out the link to the predecessor run only if the run is successfully launched.
@joshhacksthings If you don't want it to print the preceding run to stdout, I can remove it. Please direct me to an example where I can set an attribute on the run object because I don't see it in the launch method. Can I just add a predecessor_id field to the payload in submit_launch_request()?