This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Use 'B' instead of 'b' to parse/build char value.#305
Open
masamitsu-murase wants to merge 1 commit intostackless-dev:3.8-slpfrom
Open
Use 'B' instead of 'b' to parse/build char value.#305masamitsu-murase wants to merge 1 commit intostackless-dev:3.8-slpfrom
masamitsu-murase wants to merge 1 commit intostackless-dev:3.8-slpfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
pickle.loadraisesOverflowErrorif loaded content includesPyFrameObject, whosef_executingis set toSLP_FRAME_EXECUTING_INVALID, i.e.-1.Solution:
How to reproduce this issue:
OverflowErrorunexpectedly.Details:
f_executinginPyFrameObjectis declared aschar, which might be signed depending on implementation.Therefore, 'B' should be specified when
Py_BuildValueandPyArg_ParseTupleis called.f_executingis set toSLP_FRAME_EXECUTING_INVALID,PyArg_ParseTupleinframe_setstateinStackless\pickling\prickelpit.craises OverflowError.This is raised in
convertsimpleinPython\getargs.cbecauseSLP_FRAME_EXECUTING_INVALIDis less than0.