This repository was archived by the owner on Aug 12, 2024. It is now read-only.
Switch back to jdk 8 compiler and remove java modules#50
Merged
Conversation
lepistone
approved these changes
Sep 20, 2021
Member
lepistone
left a comment
There was a problem hiding this comment.
Thank you!
I agree that for the time being we still want to support Java 8, both directly for applications and for other libraries like Folsom that are still built with Java 8.
Java modules are nice but we can wait a bit for this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
dns-javais compiled with jdk 9 which breaks spotify/folsom#171 (comment)This reverts back some changes of jdk 8 -> 9 and removes the java module-info file.