Simplify RedisInterface usage when persisting Experiment alternatives#632
Merged
Simplify RedisInterface usage when persisting Experiment alternatives#632
Conversation
686cda3 to
7b9caf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When persisting a list several calls are being made to ensure that each element gets the correct index.
Instead of dealing with that on a single MULTI call, we push all elements to a tmp list, and that gets renamed it right after, using RENAME overwriting the previous list.
Also, this is only called on new experiments, and whenever an experiment configuration has changed.
Before:
Now:
Also removing one extra SISMEMBER check when calling RedisInterface#add_to_set.