Skip to content

Add a flag to restore old CSV import behaviour #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mildbyte merged 1 commit into from
Jan 5, 2022
Merged

Add a flag to restore old CSV import behaviour #605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion splitgraph/commandline/ingestion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ def csv_export(image_spec, query, file, layered):
is_flag=True,
help="Skips checking that the dataframe is compatible with the target schema.",
)
@click.option(
"--ignore-empty-strings",
is_flag=True,
help="When doing schema inference, treat empty strings as NULLs",
)
def csv_import(
repository,
table,
Expand All @@ -108,6 +113,7 @@ def csv_import(
separator,
no_header,
skip_schema_check,
ignore_empty_strings,
):
"""
Import a CSV file into a checked-out Splitgraph repository. This doesn't create a new image, use `sgr commit`
Expand Down Expand Up @@ -143,7 +149,10 @@ def csv_import(

type_overrides = dict(override_type or [])
sg_schema = infer_sg_schema(
sample, override_types=type_overrides, primary_keys=primary_key, ignore_empty_strings=False
sample,
override_types=type_overrides,
primary_keys=primary_key,
ignore_empty_strings=ignore_empty_strings,
)
logging.debug("Using Splitgraph schema: %r", sg_schema)

Expand Down